Remove unused ReactionNotificationContent #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmitrevski
approved these changes
Feb 8, 2023
nuno-vieira
reviewed
Feb 8, 2023
CHANGELOG.md
Outdated
Comment on lines
11
to
13
| ### 💥 Removed | ||
| - Remove unused ReactionNotificationContent [#2485](https://github.com/GetStream/stream-chat-swift/pull/2485) |
There was a problem hiding this comment.
Maybe we should add this to the Changed section? The 💥 might be too alarming, for something which is dead code 🤔
polqf
force-pushed
the
bugfix/remove-unused-reactions-notification-handler
branch
from
7c7467c
to
1cfe29b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
martinmitrevski
deleted the
bugfix/remove-unused-reactions-notification-handler
branch
ipavlidakis
pushed a commit
that referenced
this pull request
Feb 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves #2448
🎯 Goal
Remove misleading reference to reaction push notifications
📝 Summary
Stream does not send push notifications when a reaction is added/removed from a message, but the code was suggesting otherwise. This PR removes the unused code.
☑️ Contributor Checklist
🎁 Meme