Mark as unread #2519
Merged
Mark as unread #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 馃毇 Danger |
ipavlidakis
reviewed
Mar 3, 2023
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Outdated
Show resolved
Hide resolved
| @@ -434,6 +450,8 @@ open class ChatMessageListVC: _ViewController, | |||
| cell.setDecoration(for: .header, decorationView: delegate?.chatMessageListVC(self, headerViewForMessage: message, at: indexPath)) | |||
| cell.setDecoration(for: .footer, decorationView: delegate?.chatMessageListVC(self, footerViewForMessage: message, at: indexPath)) | |||
|
|
|||
| // TODO: Add logic to show/hide separator based on `firstUnreadMessageId` | |||
There was a problem hiding this comment.
This logic should be in the ChatChannelVC, right?
There was a problem hiding this comment.
After the rebase with develop, yeah! Did not see that your changes were applied 馃槃
|
|
||
| // THEN | ||
| XCTAssertEqual(database.writeSessionCounter, 1) | ||
| XCTAssertNotNil(readDTO(cid: cid, userId: userId)) |
There was a problem hiding this comment.
Do we want to check here the unreadCount to ensure that nothing is being updated?
Tests/StreamChatTests/Repositories/ChannelRepository_Tests.swift
Outdated
Show resolved
Hide resolved
|
It looks great 馃敟馃敟馃敟 |
polqf
force-pushed
the
feature/mark-as-unread
branch
from
fb20b11
to
b9e9012
Compare
|
Is 6.0% Duplication some sort of false-positive thingy? |
|
SonarCloud Quality Gate failed.聽 聽 |
martinmitrevski
approved these changes
Mar 6, 2023
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敆 Issue Links
https://github.com/GetStream/ios-issues-tracking/issues/285
馃幆 Goal
This PR adds an option to mark as unread a chat starting from a particular message
馃摑 Summary
Now it is possible to select a particular message, and mark the channel as unread starting from that message.
馃洜 Implementation
ChannelController exposes the first unread message id, and this one is used in the UI to show a banner (not part of this PR) to visually distinguish new messages
馃И Manual Testing Notes
Expected result:
鈽戯笍 Contributor Checklist
馃巵 Meme