Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto filtering issue with collection operators #2531

Merged
merged 5 commits into from Mar 15, 2023
Merged

Fix auto filtering issue with collection operators #2531

merged 5 commits into from Mar 15, 2023

Conversation

ipavlidakis
Copy link
Contributor

@ipavlidakis ipavlidakis commented Mar 15, 2023 •
edited

🔗 Issue Links

Provide all Jira tickets and/or Github issues related to this PR, if applicable.

🎯 Goal

Fix an issue when using auto-filtering with collection operators where the array of values, contains items of types that are not directly comparably for CoreData.

📝 Summary

The crash is caused because the values array contains items of type ChannelType which is not directly comparable for CoreData.

🛠 Implementation

We are using the same approach we used to resolve the problem with the FilterKey value. We are using the valueMapper provided by the FilterKey to map the values into a CoreData comparable format.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@ipavlidakis ipavlidakis self-assigned this Mar 15, 2023
@ipavlidakis ipavlidakis added the 🐞 Bug An issue or PR related to a bug label Mar 15, 2023
@ipavlidakis ipavlidakis marked this pull request as ready for review March 15, 2023 09:49
@ipavlidakis ipavlidakis requested a review from a team as a code owner March 15, 2023 09:49
nuno-vieira
nuno-vieira reviewed Mar 15, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ipavlidakis ipavlidakis changed the title Fix auto filtering issue with custom ChannelTypes Fix auto filtering issue with collection operators Mar 15, 2023
nuno-vieira
nuno-vieira approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@ipavlidakis ipavlidakis merged commit da484f9 into develop Mar 15, 2023
16 checks passed
@ipavlidakis ipavlidakis deleted the fix/auto-filtering-issue branch March 15, 2023 12:33
@nuno-vieira nuno-vieira mentioned this pull request Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

@polqf polqf polqf approved these changes

@nuno-vieira nuno-vieira nuno-vieira approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
🐞 Bug An issue or PR related to a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ipavlidakis @martinmitrevski @polqf @nuno-vieira