Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel list parsing failing completely if one channel fails parsing #2541

Merged

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Mar 22, 2023

馃敆 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/355

馃幆 Goal

Adds some protection when parsing the channel list. With this change, if one of the channels fails to parse, it won't completely discard the channel list.

馃洜 Implementation

We already have a mechanism to avoid this, but it was not being applied in all cases, and most importantly, it was not being applied to the ChannelListPayload so that if a channel fails to parse, it will skip it and return the other channels.

馃И Manual Testing Notes

This is only reproducible by overriding the HTTP Responses through Proxyman.
Either way, unit tests were added to cover this scenario.

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero 鈿狅笍 policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 馃悶聽Bug An issue or PR related to a bug 馃寪聽SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK labels Mar 22, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner March 22, 2023 20:06
@github-actions
Copy link

1 Warning
鈿狅笍 Big PR

Generated by 馃毇 Danger

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nuno-vieira nuno-vieira merged commit f1644bd into develop Mar 23, 2023
17 checks passed
@nuno-vieira nuno-vieira deleted the fix/channel-list-failing-parsing-if-one-channel-fails branch March 23, 2023 00:02
@testableapple testableapple mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悶聽Bug An issue or PR related to a bug 馃寪聽SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants