Fix channel list parsing failing completely if one channel fails parsing #2541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敆 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/355
馃幆 Goal
Adds some protection when parsing the channel list. With this change, if one of the channels fails to parse, it won't completely discard the channel list.
馃洜 Implementation
We already have a mechanism to avoid this, but it was not being applied in all cases, and most importantly, it was not being applied to the
ChannelListPayload
so that if a channel fails to parse, it will skip it and return the other channels.馃И Manual Testing Notes
This is only reproducible by overriding the HTTP Responses through Proxyman.
Either way, unit tests were added to cover this scenario.
鈽戯笍 Contributor Checklist