Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for custom Firebase Storage CDN #2940

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

martinmitrevski
Copy link
Contributor

馃敆 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/678.

馃幆 Goal

Link a Firebase Storage implementation for our custom CDN.

馃摑 Summary

Provide bullet points with the most important changes in the codebase.

馃洜 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

馃帹 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

馃И Manual Testing Notes

Explain how this change can be tested manually, if applicable.

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero 鈿狅笍 policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

馃巵 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@martinmitrevski martinmitrevski requested a review from a team as a code owner December 18, 2023 12:42
Copy link

1 Warning
鈿狅笍 Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 馃毇 Danger

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃帀

@nuno-vieira nuno-vieira merged commit ea823b4 into develop Dec 18, 2023
15 checks passed
@nuno-vieira nuno-vieira deleted the custom-firebase-cdn branch December 18, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants