Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for the async voice feature on SwiftUI #2942

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Links

Provide all Jira tickets and/or Github issues related to this PR, if applicable.

🎯 Goal

Describe why we are making this change.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@martinmitrevski martinmitrevski requested a review from a team as a code owner December 19, 2023 13:03
@martinmitrevski martinmitrevski marked this pull request as draft December 19, 2023 13:03
Copy link

github-actions bot commented Dec 19, 2023

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

Copy link
Contributor

@testableapple testableapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Although I didn't quite get the need of having two identical .md files 😄

docusaurus/docs/iOS/swiftui/audio-recording.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/swiftui/audio-recording.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/swiftui/audio-recording.md Outdated Show resolved Hide resolved
@martinmitrevski martinmitrevski marked this pull request as ready for review December 19, 2023 14:00
@martinmitrevski martinmitrevski merged commit 3f82c6c into develop Dec 20, 2023
15 checks passed
@martinmitrevski martinmitrevski deleted the async-voice-docs branch December 20, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants