Fix messages failing to be deleted when pending updates to the server

[nuno-vieira]

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/685

🎯 Goal

Fix messages failing to be deleted when pending updates to the server.

📝 Summary

• Fix messages failing to be deleted when pending updates to the server
• Makes sure message actions always show at least Edit and Delete action
• Fixes actions not appearing for local-only messages with BG Mapping enabled

🛠 Implementation

The root cause of the problem is that we were incorrectly calculating the logic for isWaitingToBeSentToTheServer, which has now been renamed to isLocalOnly to better describe the goal of the property. Before, if a message was being edited, but not yet published, we would assume it was local only. This is incorrect since the message is already in the server, since it was published once, even tho it does not have the most updated data.

While debugging this issue, I also fixed a issue that was happening with background mapping. The issue is similar to this one: #2922. Because the ChatMessageController.message is not available on the main thread with background mapping, sometimes it was returning nil.

🧪 Manual Testing Notes

Fix messages failing to be deleted when pending updates to the server:
N/A
Right now this not manually testable in our Demo app, since we do not allow doing any message action while the message is being edited.

Fixes actions not appearing for local-only messages with BG Mapping enabled

1. Turn off Wi-Fi
2. Send a message
3. Long press the message
4. Message Actions should appear

☑️ Contributor Checklist

• I have signed the Stream CLA (required)
• This change follows zero ⚠️ policy (required)
• This change should be manually QAed
• Changelog is updated with client-facing changes
• New code is covered by unit tests
• Comparison screenshots added for visual changes
• Affected documentation updated (docusaurus, tutorial, CMS)

[martinmitrevski]

LGTM ✅ Just added one question.

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

47 New issues
0 Security Hotspots
91.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud