Missing barrier flag in ConnectionRepository when mutating state #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the state on a concurrent queue
laevandus
added
🐞 Bug
laevandus
commented
Jan 30, 2024
| @@ -470,7 +470,7 @@ final class ConnectionRepository_Tests: XCTestCase { | |||
| XCTAssertEqual(result?.value, connectionId) | |||
| } | |||
|
|
|||
| func test_connectionId_doesNotDeadlock() { | |||
| func test_connectionId_triggersCompletions_whenConcurrentlyCalled() { | |||
There was a problem hiding this comment.
Just renamed to match with naming to a similar test in PR 2986
martinmitrevski
approved these changes
Jan 30, 2024
nuno-vieira
approved these changes
Jan 30, 2024
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Follow-up to PR 2985
🎯 Goal
Better thread-safety in ConnectionRepository
📝 Summary
Barrier flag was missing for mutating work item
🛠 Implementation
Since we use a concurrent queue then all the mutating work items must use a barrier flag for making sure other concurrently running work items do not try to read the state what is being mutated.
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)