New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix composer link preview overridden by previous enrichment #3025
Fix composer link preview overridden by previous enrichment #3025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅ Just please update the changelog entry a bit.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
🔗 Issue Links
None
🎯 Goal
Fix composer link preview overriding actual current link preview
📝 Summary
🛠 Implementation
The proper way to do this is to cancel the previous request whenever we send a new request to enrich the url. The problem is that right now we do not have support for cancellable requests in our SDK, mostly because of tech debt issues. So right now, the best way to improve this is when we show the link preview we need to make sure that url is still the one in the composer input.
🧪 Manual Testing Notes
Link preview should not show after sending the message
Valid old link preview should not override current link preview
Incorrect old link preview should not override current link preview
☑️ Contributor Checklist