Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native swipe-back gesture overridden by swipe to reply #3029

Merged

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Feb 14, 2024

馃敆 Issue Links

Relates to #3010

馃幆 Goal

Fix native swipe-back gesture overridden by swipe to reply.

馃洜 Implementation

We use the shouldRequireFailureOf delegate method to check if the gesture should be overriden or not. If the active gesture is the one from swipe back, then we do not trigger the swipe-to-reply.

This issue was a problem with custom back buttons. So a custom back button was added to the Demo App to make sure we can test this.

馃И Manual Testing Notes

  1. Open a channel
  2. Swipe back to go to the channel list
  3. Open the channel again
  4. Swipe to reply a message on the left
  5. Both 2. and 3. should work

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero 鈿狅笍 policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 馃悶聽Bug An issue or PR related to a bug 馃帹聽SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Feb 14, 2024
@nuno-vieira nuno-vieira self-assigned this Feb 14, 2024
@nuno-vieira nuno-vieira requested a review from a team as a code owner February 14, 2024 15:15
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 14, 2024

Copy link
Contributor

@pm-dev pm-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 馃憤

@nuno-vieira
Copy link
Member Author

Force merging due to flaky E2E Test

@nuno-vieira nuno-vieira merged commit 44ee1cb into develop Feb 15, 2024
14 of 15 checks passed
@nuno-vieira nuno-vieira deleted the fix/native-swipe-back-gesture-overriden-by-swipe-to-reply branch February 15, 2024 10:16
@nuno-vieira nuno-vieira mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悶聽Bug An issue or PR related to a bug 馃帹聽SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants