New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parallel attachment uploading #3034
Conversation
7b166cd
to
927b897
Compare
Quality Gate passedIssues Measures |
newAttachmentIds.forEach { | ||
pendingAttachmentIDs.insert($0) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative could be pendingAttachmentIDs.formUnion(newAttachmentIds)
. But it does not matter much.
@nuno-vieira The flickering in the gallery view is going to be taken care by a separate issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement 馃憦 I also tested on SwiftUI, it works well there too.
Do we have a follow up about/ideas to fix the flickering?
@laevandus @martinmitrevski The flickering requires rebuilding the Gallery View, unfortunately, so we would need a new GalleryViewInjector implementation. |
馃敆 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/701
馃幆 Goal
Adds parallel attachment uploading
馃摑 Summary
馃洜 Implementation
Before, we were uploading the next attachment only when the current attachment finished uploading. This is not needed at all. We can start all uploads at the same time.
馃帹 Showcase
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-02-16.at.18.30.34.mp4
馃И Manual Testing Notes
Scenario 1
Scenario 2
鈽戯笍 Contributor Checklist