Fix race condition when dismissing the gallery causing the UI to be blocked #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🐞 Bug
nuno-vieira
changed the title
|
laevandus
approved these changes
Feb 20, 2024
martinmitrevski
approved these changes
Feb 20, 2024
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| - Fix `CGBitmapContextInfoCreate` console log warning when creating merged channel avatars [#3018](https://github.com/GetStream/stream-chat-swift/pull/3018) | |||
| - Slight performance improvement in the message list by caching `NSRegularExpression` in `MarkdownFormatter` [#3020](https://github.com/GetStream/stream-chat-swift/pull/3020) | |||
| - Slight performance improvement in the message list by skipping channel list updates when it is not visible [#3021](https://github.com/GetStream/stream-chat-swift/pull/3021) | |||
| - Fix race condition when dismissing the gallery causing the UI to be blocked [#3037](https://github.com/GetStream/stream-chat-swift/pull/3037) | |||
There was a problem hiding this comment.
Would be good to clarify it's an edge case. Reading it like this sounds like it was common.
There was a problem hiding this comment.
If it is a race condition, usually it is already rare 🤔
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Will fix #2975
🎯 Goal
Fix UI getting blocked after swiping up the gallery view.
🛠 Implementation
The issue is that a cancellation and a regular dismissal were happening at the same time, causing a race condition. A cancel was getting called twice, and with
completeTransition(true), causing the transition to finish when it should not.🧪 Manual Testing Notes
☑️ Contributor Checklist