Fix invalid token triggering token refresh in an infinite loop

[nuno-vieira]

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/739
Related to #3032

🎯 Goal

Fix invalid token calling token refresh in an infinite loop

🛠 Implementation

We were incorrectly triggering a token refresh whenever we received an invalid token. The token refresh should only be triggered when the token is expired. If a token is invalid, it is because of a programming error, so if we retry it, it will be in an infinite loop:

1. Get Token
2. Signature is Invalid
3. Refresh Token
4. Signature is Invalid
5. Go to 3.

With this change, if a token is invalid, we simply stop retrying, and a manual retry should be done.

🧪 Manual Testing Notes

1. Open Demo App Configuration
2. Tap on tokenRefreshDetails
3. Add an invalid secret to the token
4. Open the app
5. The channel list fetch should fail, and you should not see a loop of "Token refreshing" in the console log.

☑️ Contributor Checklist

• I have signed the Stream CLA (required)
• This change follows zero ⚠️ policy (required)
• This change should be manually QAed
• Changelog is updated with client-facing changes
• New code is covered by unit tests
• Comparison screenshots added for visual changes
• Affected documentation updated (docusaurus, tutorial, CMS)

[sonarcloud]

Quality Gate passed

Issues
47 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[martinmitrevski]

LGTM ✅