Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "Edited" label when message text is edited #3059

Merged
merged 13 commits into from Mar 6, 2024

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Mar 5, 2024

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/750

🎯 Goal

Add support for "Edited" label when message text is edited.

📝 Summary

  • Exposes ChatMessage.textUpdatedAt
  • Adds Components.isMessageEditedLabelEnabled
  • Adds "Edited" label when message text is edited

🎨 Showcase

🧪 Manual Testing Notes

  1. Send a message
  2. Edit the text of the message
  3. The "Edited" label should appear

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK ✅ Feature An issue or PR related to a feature labels Mar 5, 2024
@nuno-vieira nuno-vieira requested a review from a team as a code owner March 5, 2024 15:55
@nuno-vieira nuno-vieira changed the title Add support for "Edited at" label when message text is edited Add support for "Edited" label when message text is edited Mar 5, 2024
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Added 2 comments, curious about your thoughts.

@nuno-vieira nuno-vieira added the 🤞 Ready For QA A PR that is Ready for QA label Mar 5, 2024
@nuno-vieira nuno-vieira marked this pull request as draft March 6, 2024 14:23
@nuno-vieira nuno-vieira marked this pull request as ready for review March 6, 2024 14:23
@testableapple testableapple added 🟢 QAed A PR that was QAed and removed 🤞 Ready For QA A PR that is Ready for QA labels Mar 6, 2024
@Stream-iOS-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric release/4.49.0 branch performance status
MessageList Hitches total duration 20 ms 5.0 ms 75.0% 🔼 🟢
Duration 5 s 2.5 s 50.0% 🔼 🟢
Hitch time ratio 10 ms per s 2.0 ms per s 80.0% 🔼 🟢
Frame rate 100 fps 78.2 fps 21.8% 🔼 🟢
Number of hitches 1 0 100.0% 🔼 🟢
ChannelList Hitches total duration 20 ms 10.8 ms 46.0% 🔼 🟢
Duration 5 s 2.6 s 48.0% 🔼 🟢
Hitch time ratio 10 ms per s 4.2 ms per s 58.0% 🔼 🟢
Frame rate 100 fps 74.5 fps 25.5% 🔼 🟢
Number of hitches 1 0 100.0% 🔼 🟢

Copy link

sonarcloud bot commented Mar 6, 2024

@nuno-vieira nuno-vieira force-pushed the add/support-edited-at-message branch from 9a491a3 to cdb5386 Compare March 6, 2024 14:49
@nuno-vieira nuno-vieira enabled auto-merge (squash) March 6, 2024 15:24
@nuno-vieira nuno-vieira merged commit 8eef5a6 into develop Mar 6, 2024
13 of 14 checks passed
@nuno-vieira nuno-vieira deleted the add/support-edited-at-message branch March 6, 2024 16:05
@testableapple testableapple mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Feature An issue or PR related to a feature 🟢 QAed A PR that was QAed 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants