Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mute expiration support when muting a channel #3083

Merged
merged 4 commits into from Mar 14, 2024

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Mar 13, 2024

馃敆 Issue Links

Resolves #2807
Resolves https://github.com/GetStream/ios-issues-tracking/issues/762

馃幆 Goal

Add mute expiration support when muting a channel

馃И Manual Testing Notes

  • Open a channel list
  • Swipe a channel
  • Tap on three dots
  • Tap on a "Mute channel with expiration" button
  • Set up an expiration duration (e.g.: 10000)
  • Write a message to this channel from a different account
  • Unread count bubble does not appear
  • Wait expiration duration
  • Write one more message
  • Unread count bubble should appear

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero 鈿狅笍 policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

馃巵 Meme

gif

@testableapple testableapple requested a review from a team as a code owner March 13, 2024 19:17
@testableapple testableapple force-pushed the feature/support-channel-mute-expiration branch from 3be9938 to 94b3361 Compare March 13, 2024 19:18
@testableapple testableapple added 馃寪聽SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 鉁吢燜eature An issue or PR related to a feature labels Mar 13, 2024
@Stream-iOS-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 5.01 ms 49.9% 馃敿 馃煝
Duration 2.6 s 2.54 s 2.31% 馃敿 馃煝
Hitch time ratio 4 ms per s 1.97 ms per s 50.75% 馃敿 馃煝
Frame rate 79 fps 78.47 fps 0.67% 馃敿 馃煝
Number of hitches 1 0.6 40.0% 馃敿 馃煝
ChannelList Hitches total duration 12.5 ms 1.67 ms 86.64% 馃敿 馃煝
Duration 2.6 s 2.55 s 1.92% 馃敿 馃煝
Hitch time ratio 5 ms per s 0.66 ms per s 86.8% 馃敿 馃煝
Frame rate 76 fps 75.1 fps 1.18% 馃敿 馃煝
Number of hitches 1.2 0.2 83.33% 馃敿 馃煝

Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to add, looks nice

Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 馃憦

@testableapple testableapple added the 馃 Ready For QA A PR that is Ready for QA label Mar 14, 2024
@laevandus
Copy link
Contributor

laevandus commented Mar 14, 2024

I tried mute/unmute with expiration and without expiration. Worked correctly.

@laevandus laevandus added 馃煝 QAed A PR that was QAed and removed 馃 Ready For QA A PR that is Ready for QA labels Mar 14, 2024
Copy link
Contributor

@ipavlidakis ipavlidakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 馃殺

Copy link

sonarcloud bot commented Mar 14, 2024

@testableapple testableapple merged commit 88e1c7a into develop Mar 14, 2024
15 checks passed
@testableapple testableapple deleted the feature/support-channel-mute-expiration branch March 14, 2024 14:05
@laevandus laevandus mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
鉁吢燜eature An issue or PR related to a feature 馃煝 QAed A PR that was QAed 馃寪聽SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a Mute Duration
6 participants