Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Message View not updated when new translations are added or removed #3103

Merged

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Mar 19, 2024

馃敆 Issue Links

Resolves #3099

馃幆 Goal

Fix Message View not updated when new translations are added or removed.

馃И Manual Testing Notes

N/A (At the moment we don't have a way to add multiple translations to a message in the DemoApp)

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero 鈿狅笍 policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 馃悶聽Bug An issue or PR related to a bug 馃帹聽SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Mar 19, 2024
@nuno-vieira nuno-vieira requested a review from a team as a code owner March 19, 2024 19:31
@Stream-iOS-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 3.34 ms 66.6% 馃敿 馃煝
Duration 2.6 s 2.55 s 1.92% 馃敿 馃煝
Hitch time ratio 4 ms per s 1.31 ms per s 67.25% 馃敿 馃煝
Frame rate 79 fps 78.41 fps 0.75% 馃敿 馃煝
Number of hitches 1 0.4 60.0% 馃敿 馃煝
ChannelList Hitches total duration 12.5 ms 15.86 ms -26.88% 馃斀 馃敶
Duration 2.6 s 2.54 s 2.31% 馃敿 馃煝
Hitch time ratio 5 ms per s 6.24 ms per s -24.8% 馃斀 馃敶
Frame rate 76 fps 74.38 fps 2.13% 馃敿 馃煝
Number of hitches 1.2 1.6 -33.33% 馃斀 馃敶

Copy link

sonarcloud bot commented Mar 19, 2024

@nuno-vieira nuno-vieira merged commit ac2148a into develop Mar 20, 2024
15 checks passed
@nuno-vieira nuno-vieira deleted the fix/message-not-updated-when-new-translation-added branch March 20, 2024 00:10
@laevandus laevandus mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悶聽Bug An issue or PR related to a bug 馃帹聽SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

See Original and Translated Message
3 participants