New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for defining file size limit per attachment type #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
🎨 SDK: StreamChatUI
Tasks related to the StreamChatUI SDK
✅ Feature
An issue or PR related to a feature
labels
Mar 20, 2024
nuno-vieira
force-pushed
the
add/size-limit-per-attachment-type
branch
from
March 20, 2024 17:44
64147b6
to
705f2d5
Compare
StreamChat XCMetrics
|
laevandus
approved these changes
Mar 21, 2024
Converted to draft, to wait for the Dashboard implementation |
Quality Gate passedIssues Measures |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
✅ Feature
An issue or PR related to a feature
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
🎨 SDK: StreamChatUI
Tasks related to the StreamChatUI SDK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/757
🎯 Goal
Add support for defining a file size limit per type through Stream's Dashboard App Settings.
📝 Summary
sizeLimitInBytes
inChatClient.appSettings.fileUploadConfig
andChatClient.appSettings.imageUploadConfig
ChatClientConfig.maxAttachmentSize
🧪 Manual Testing Notes
NOTE: At the moment, changing the value in the dashboard is still not supported, so to test this it is required to override the values from Proxyman or by using the Stream's CLI API.
Scenario 1 - Value not set in the Dashboard
Scenario 2 - Set image limit in the dashboard
Scenario 3 - Set file limit in the dashboard
☑️ Contributor Checklist