New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix member list not updated after moderator is demoted #3132
Merged
nuno-vieira
merged 8 commits into
develop
from
fix/member-list-query-with-moderators-not-updated-when-removed
Apr 8, 2024
Merged
Fix member list not updated after moderator is demoted #3132
nuno-vieira
merged 8 commits into
develop
from
fix/member-list-query-with-moderators-not-updated-when-removed
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🐞 Bug
An issue or PR related to a bug
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
labels
Apr 8, 2024
nuno-vieira
changed the title
Fix member list not updated after moderator is demoted
Fix member list not updated after moderator is demoted/promoted
Apr 8, 2024
nuno-vieira
changed the title
Fix member list not updated after moderator is demoted/promoted
Fix member list not updated after moderator is demoted
Apr 8, 2024
laevandus
reviewed
Apr 8, 2024
laevandus
approved these changes
Apr 8, 2024
martinmitrevski
approved these changes
Apr 8, 2024
testableapple
added
🤞 Ready For QA
A PR that is Ready for QA
🟢 QAed
A PR that was QAed
and removed
🤞 Ready For QA
A PR that is Ready for QA
labels
Apr 8, 2024
testableapple
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
Quality Gate passedIssues Measures |
nuno-vieira
deleted the
fix/member-list-query-with-moderators-not-updated-when-removed
branch
April 8, 2024 15:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 Bug
An issue or PR related to a bug
🟢 QAed
A PR that was QAed
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/785
🎯 Goal
Fix the member list not updated after the moderator is demoted.
📝 Summary
At the moment, the backend does not fire any event to notify that a moderator has been demoted or promoted. So, if we have a moderator in the local DB that was demoted, it won't be removed from the local DB, so it will never be deleted.
🛠 Implementation
Even if the backend does not fire any event, we should also make sure that when opening the member list for the first time, that we clear the cache, to make sure that removed members do not get included in the response.
🧪 Manual Testing Notes
Note: Make sure you have the latest update of
stream-cli
on your machine.stream-cli chat promote-moderators --type messaging --id 2884427A-E r2-d2 leia_organa
stream-cli chat demote-moderators --type messaging --id 2884427A-E leia_organa
☑️ Contributor Checklist