Fix triggering user query calls whenever a new user was added in UserListController

[nuno-vieira]

🔗 Issue Links

Relates to https://github.com/GetStream/ios-issues-tracking/issues/800

🎯 Goal

Fixes adding new users causing additional HTTP calls just to check if the new user is part of the query.

📝 Summary

The responsible for this was NewUserQueryUpdater. This is a really old worker that we had, and it seems like we had one of these for channel lists as well, and then we had to remove it because of problems. This approach is for sure a no go, creating an HTTP call for every new user just to check if it stills matches the query is not recommended by the backend team, and it can be a pretty fragile solution. Observing this in the UserListController also seems to be an overkill. Only for the MemberListController this is useful. So for the time being, we will just remove this. If customers want UserListController to be reactive, we will need to implement the automatic query filter and/or the filter block approach that we have for channel lists.

References:

• Old NewQueryChannelUpdater
• Introduction of the new Channel List linking approach: [CIS-1157] Introduce linking delegate callbacks #1438
• Removal of NewQueryChannelUpdater

🧪 Manual Testing Notes

N/A

☑️ Contributor Checklist

• I have signed the Stream CLA (required)
• This change follows zero ⚠️ policy (required)
• This change should be manually QAed
• Changelog is updated with client-facing changes
• New code is covered by unit tests
• Comparison screenshots added for visual changes
• Affected documentation updated (docusaurus, tutorial, CMS)

[martinmitrevski]

LGTM ✅

[martinmitrevski]

Thinking if we should mention that the UserListController is no longer reactive, wdyt?

[nuno-vieira]

Yeah, I was thinking about that too, but I was afraid it might warn customers for no important reason, since most of them won't care about this, but maybe better to be transparent, so I'll add this 👍

[nuno-vieira]

Done ✅

[Stream-iOS-Bot]

StreamChat XCMetrics

target	metric	benchmark	branch	performance	status
MessageList	Hitches total duration	10 ms	6.68 ms	33.2% 🔼	🟢
	Duration	2.6 s	2.55 s	1.92% 🔼	🟢
	Hitch time ratio	4 ms per s	2.63 ms per s	34.25% 🔼	🟢
	Frame rate	79 fps	78.16 fps	1.06% 🔼	🟢
	Number of hitches	1	0.6	40.0% 🔼	🟢
ChannelList	Hitches total duration	12.5 ms	14.18 ms	-13.44% 🔽	🔴
	Duration	2.6 s	2.21 s	15.0% 🔼	🟢
	Hitch time ratio	5 ms per s	6.19 ms per s	-23.8% 🔽	🔴
	Frame rate	76 fps	77.89 fps	-2.49% 🔽	🟡
	Number of hitches	1.2	1.6	-33.33% 🔽	🔴

[sonarcloud]

Quality Gate passed

Issues
68 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud