Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marking channel read after leaving channel view #3193

Merged
merged 2 commits into from
May 13, 2024

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented May 10, 2024

馃敆 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/777
Related to #3089

馃幆 Goal

Fix marking a channel read even after the user has left the channel view.

馃摑 Summary

This could happen in a case where the user left the channel view, but the debouncer would still trigger a request to markRead.

馃洜 Implementation

Now, when the user leaves the channel view, we cancel the throttler.

馃И Manual Testing Notes

Follow steps of #3089

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero 鈿狅笍 policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 馃悶聽Bug An issue or PR related to a bug 馃帹聽SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels May 10, 2024
@nuno-vieira nuno-vieira requested a review from a team as a code owner May 10, 2024 15:47
@Stream-iOS-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 5.01 ms 49.9% 馃敿 馃煝
Duration 2.6 s 2.54 s 2.31% 馃敿 馃煝
Hitch time ratio 4 ms per s 1.96 ms per s 51.0% 馃敿 馃煝
Frame rate 79 fps 78.14 fps 1.09% 馃敿 馃煝
Number of hitches 1 0.4 60.0% 馃敿 馃煝
ChannelList Hitches total duration 12.5 ms 21.69 ms -73.52% 馃斀 馃敶
Duration 2.6 s 2.54 s 2.31% 馃敿 馃煝
Hitch time ratio 5 ms per s 8.55 ms per s -71.0% 馃斀 馃敶
Frame rate 76 fps 73.92 fps 2.74% 馃敿 馃煝
Number of hitches 1.2 1.6 -33.33% 馃斀 馃敶

Copy link

sonarcloud bot commented May 10, 2024

@nuno-vieira nuno-vieira merged commit ee2b7b1 into develop May 13, 2024
15 checks passed
@nuno-vieira nuno-vieira deleted the fix/channel-marking-read-after-leaving-channel branch May 13, 2024 08:54
@laevandus laevandus mentioned this pull request May 13, 2024
@laevandus
Copy link
Contributor

Verified it manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悶聽Bug An issue or PR related to a bug 馃帹聽SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants