Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChatSuggestionVC is getting redisplayed and commands shortcut not working #3215

Merged
merged 9 commits into from
May 21, 2024
Merged

ChatSuggestionVC is getting redisplayed and commands shortcut not working #3215

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8575705
Do not update suggestion view height while user is scrolling
laevandus May 20, 2024
33998b6
Reduce suggestion view height updates while scrolling it
laevandus May 20, 2024
15a8bb9
Fix commands suggestions not showing
nuno-vieira May 20, 2024
4af4875
Cleanup and centralize the logic in updateSuggestions() function
nuno-vieira May 20, 2024
f80b00b
Remove `updateMentionSuggestions()` and `updateCommandSuggestions()` …
nuno-vieira May 20, 2024
aadb4b8
Add a notice about replaced methods in ChatSuggestionVC and reword ot…
laevandus May 20, 2024
d1742bc
Add test coverage to avoid regressions
nuno-vieira May 20, 2024
b5e8796
Merge branch 'develop' into fix/suggestion-view-updates
nuno-vieira May 20, 2024
075998e
Update CHANGELOG.md
nuno-vieira May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
### ✅ Added
- Add a new state layer with async-await and observable state objects ([learn more](https://getstream.io/chat/docs/sdk/ios/state-layer/state-layer-overview/)) [#3177](https://github.com/GetStream/stream-chat-swift/pull/3177)

## StreamChatUI
### 🐞 Fixed
- Do not re-displaying suggestion view on each character change [#3215](https://github.com/GetStream/stream-chat-swift/pull/3215)
- Reduce suggestion view height updates while scrolling it [#3215](https://github.com/GetStream/stream-chat-swift/pull/3215)

# [4.55.0](https://github.com/GetStream/stream-chat-swift/releases/tag/4.55.0)
_May 13, 2024_

Expand Down
3 changes: 2 additions & 1 deletion Sources/StreamChatUI/Composer/ComposerVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,6 @@ open class ComposerVC: _ViewController,
updateCommandSuggestions()
updateMentionSuggestions()
updatePlaceholderLabel()
dismissSuggestions()
}

open func updateText() {
Expand Down Expand Up @@ -710,6 +709,8 @@ open class ComposerVC: _ViewController,
self?.showMentionSuggestions(for: typingMention, mentionRange: mentionRange)
}
return
laevandus marked this conversation as resolved.
Show resolved Hide resolved
} else {
dismissSuggestions()
laevandus marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down
2 changes: 2 additions & 0 deletions Sources/StreamChatUI/Composer/Suggestions/ChatSuggestionsVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,14 @@ open class ChatSuggestionsVC: _ViewController,
options: [.new],
changeHandler: { [weak self] collectionView, change in
guard let self = self, let newSize = change.newValue else { return }
guard !collectionView.isTrackingOrDecelerating else { return }
nuno-vieira marked this conversation as resolved.
Show resolved Hide resolved

// NOTE: The defaultRowHeight height value will be used only once to set visibleCells
// once again, not looping it to 0 value so this controller can resize again.
let cellHeight = collectionView.visibleCells.first?.bounds.height ?? self.defaultRowHeight

let newHeight = min(newSize.height, cellHeight * self.numberOfVisibleRows)
guard self.heightConstraints.constant != newHeight else { return }
self.heightConstraints.constant = newHeight
}
)
Expand Down
Loading