-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChatSuggestionVC
is getting redisplayed and commands shortcut not working
#3215
Conversation
4fa7a94
to
33998b6
Compare
StreamChat XCMetrics
|
…to make it simpler to control the suggestions logic
4927ff7
to
aadb4b8
Compare
Generated by 🚫 Danger |
cb6da0c
to
d1742bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
Quality Gate passedIssues Measures |
ChatSuggestionVC
is getting redisplayed on each character changeChatSuggestionVC
is getting redisplayed and commands shortcut not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QAed, looks good 👍
The only open question left is regarding an old channel with multiple users with no names. Discussing in Slack atm.
🔗 Issue Links
Resolves ios-issues-tracking/826
🎯 Goal
/
not showing suggestions🎨 Showcase
🧪 Manual Testing Notes
Issue 1: mentioning users
Observe that the suggestion view is updated correctly (is open until there are matches, gets closed when no matches etc)
Issue 2:
/
command not showing suggestions/
and try to interact with the giphy commandResult: Command suggestions appear.
☑️ Contributor Checklist