Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatSuggestionVC is getting redisplayed and commands shortcut not working #3215

Merged
merged 9 commits into from
May 21, 2024

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented May 20, 2024

🔗 Issue Links

Resolves ios-issues-tracking/826

🎯 Goal

  • Do not dismiss and show the suggestion view on every character change
  • Optimise suggestion view height updates
  • / not showing suggestions

🎨 Showcase

Before After
before after

🧪 Manual Testing Notes

Issue 1: mentioning users

  1. Open a channel with many members
  2. Try to mention someone which triggers showing the suggestion view
    Observe that the suggestion view is updated correctly (is open until there are matches, gets closed when no matches etc)

Issue 2: / command not showing suggestions

  1. Type / and try to interact with the giphy command
    Result: Command suggestions appear.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@laevandus laevandus added the 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK label May 20, 2024
@laevandus laevandus requested a review from a team as a code owner May 20, 2024 11:44
@laevandus laevandus force-pushed the fix/suggestion-view-updates branch from 4fa7a94 to 33998b6 Compare May 20, 2024 11:48
@Stream-iOS-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 1.67 ms 83.3% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 0.66 ms per s 83.5% 🔼 🟢
Frame rate 79 fps 78.64 fps 0.46% 🔼 🟢
Number of hitches 1 0.2 80.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 0.0 ms 100.0% 🔼 🟢
Duration 2.6 s 0.82 s 68.46% 🔼 🟢
Hitch time ratio 5 ms per s 0.0 ms per s 100.0% 🔼 🟢
Frame rate 76 fps 63.7 fps 16.18% 🔼 🟢
Number of hitches 1.2 0.0 100.0% 🔼 🟢

@laevandus laevandus force-pushed the fix/suggestion-view-updates branch from 4927ff7 to aadb4b8 Compare May 20, 2024 13:21
@laevandus laevandus added the 🤞 Ready For QA A PR that is Ready for QA label May 20, 2024
Copy link

1 Warning
⚠️ The changes should be manually QAed before the Pull Request will be merged

Generated by 🚫 Danger

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 20, 2024

@laevandus laevandus changed the title ChatSuggestionVC is getting redisplayed on each character change ChatSuggestionVC is getting redisplayed and commands shortcut not working May 21, 2024
@testableapple testableapple added 🟢 QAed A PR that was QAed and removed 🤞 Ready For QA A PR that is Ready for QA labels May 21, 2024
Copy link
Contributor

@testableapple testableapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QAed, looks good 👍
The only open question left is regarding an old channel with multiple users with no names. Discussing in Slack atm.

@laevandus laevandus merged commit 67b13c8 into develop May 21, 2024
15 checks passed
@laevandus laevandus deleted the fix/suggestion-view-updates branch May 21, 2024 10:18
@Stream-iOS-Bot Stream-iOS-Bot mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟢 QAed A PR that was QAed 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants