Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.56.1 Release #3219

Merged
merged 5 commits into from
May 23, 2024
Merged

4.56.1 Release #3219

merged 5 commits into from
May 23, 2024

Conversation

Stream-iOS-Bot
Copy link
Collaborator

StreamChatUI

🐞 Fixed

  • Do not re-display suggestion view on each character change #3215
  • Fix command suggestions not appearing #3215
  • Reduce suggestion view height updates while scrolling #3215

🔄 Changed

  • Replace updateCommandSuggestions() and updateMentionSuggestions() with updateSuggestions() in ChatSuggestionVC #3215

testableapple and others added 5 commits May 20, 2024 17:23
@testableapple
Fix typo in changelog (#3216)
91af29d
@laevandus @nuno-vieira
ChatSuggestionVC is getting redisplayed and commands shortcut not w…
67b13c8 
…orking (#3215)

* Do not update suggestion view height while user is scrolling

* Reduce suggestion view height updates while scrolling it

* Fix commands suggestions not showing

* Cleanup and centralize the logic in updateSuggestions() function

* Remove `updateMentionSuggestions()` and `updateCommandSuggestions()` to make it simpler to control the suggestions logic

* Add a notice about replaced methods in ChatSuggestionVC and reword other changes

* Add test coverage to avoid regressions

* Update CHANGELOG.md

---------

Co-authored-by: Nuno Vieira <nuno.fcvieira93@gmail.com>
@laevandus @dependabot
Bump rexml from 3.2.6 to 3.2.8 (#3218)
e3ba0d5 
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.6 to 3.2.8.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.2.6...v3.2.8)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@testableapple
Returned missed test run (#3217)
95f4a88
Bump 4.56.1
a834ab0
@Stream-iOS-Bot Stream-iOS-Bot requested a review from a team as a code owner May 23, 2024 06:25
@github-actions GitHub Actions
Copy link

Build for regression testing №123457009 has been uploaded to TestFlight 🎁

@Stream-iOS-Bot
Copy link
Collaborator Author

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 5.84 ms 41.6% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 2.29 ms per s 42.75% 🔼 🟢
Frame rate 79 fps 78.31 fps 0.87% 🔼 🟢
Number of hitches 1 0.6 40.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 16.69 ms -33.52% 🔽 🔴
Duration 2.6 s 2.56 s 1.54% 🔼 🟢
Hitch time ratio 5 ms per s 6.54 ms per s -30.8% 🔽 🔴
Frame rate 76 fps 74.44 fps 2.05% 🔼 🟢
Number of hitches 1.2 1.4 -16.67% 🔽 🔴

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
103 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Stream-iOS-Bot
Copy link
Collaborator Author

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 6.68 ms 33.2% 🔼 🟢
Duration 2.6 s 2.56 s 1.54% 🔼 🟢
Hitch time ratio 4 ms per s 2.61 ms per s 34.75% 🔼 🟢
Frame rate 79 fps 78.12 fps 1.11% 🔼 🟢
Number of hitches 1 0.6 40.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 16.69 ms -33.52% 🔽 🔴
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 5 ms per s 6.56 ms per s -31.2% 🔽 🔴
Frame rate 76 fps 74.31 fps 2.22% 🔼 🟢
Number of hitches 1.2 1.2 0.0% 🔽 🟢

@laevandus laevandus merged commit a834ab0 into main May 23, 2024
16 of 17 checks passed
@laevandus laevandus deleted the release/4.56.1 branch May 23, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laevandus laevandus laevandus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stream-iOS-Bot @laevandus @testableapple