Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: EnrichedReaction latest_children and own_children type declarations #483

Merged

Conversation

MartinCupela
Copy link
Collaborator

EnrichedReaction.latest_children and EnrichedReaction.own_children are records. Their values are arrays of child reactions, not single child reactions objects. See the attached screenshot:

image

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2021

Size Change: 0 B

Total Size: 99.3 kB

ℹ️ View Unchanged
Filename Size Change
dist/js_min/getstream.js 31.4 kB 0 B
dist/js/getstream.js 67.8 kB 0 B

compressed-size-action

Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏻

@ferhatelmas ferhatelmas merged commit 2d11b1d into main Nov 26, 2021
@ferhatelmas ferhatelmas deleted the fix-child-reaction-type-on-latest_children-own_children branch November 26, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants