Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: EnrichedReaction latest_children and own_children type declarations #483

Merged
merged 2 commits into from
Nov 26, 2021
Merged

FIX: EnrichedReaction latest_children and own_children type declarations #483

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5da857
fix EnrichedReaction.latest_children and own_children are records wit…
MartinCupela Nov 24, 2021
390c7bf
Merge branch 'main' into fix-child-reaction-type-on-latest_children-o…
ferhatelmas Nov 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/reaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,22 @@ export type Reaction<T extends UR = UR> = {

export type ReactionAPIResponse<T extends UR = UR> = APIResponse & Reaction<T>;

export type ChildReactionsRecords<
ReactionType extends UR = UR,
ChildReactionType extends UR = UR,
UserType extends UR = UR
// eslint-disable-next-line no-use-before-define
> = Record<string, EnrichedReaction<ReactionType, ChildReactionType, UserType>[]>;

export type EnrichedReaction<
ReactionType extends UR = UR,
ChildReactionType extends UR = UR,
UserType extends UR = UR
> = Reaction<ReactionType | ChildReactionType> & {
children_counts: Record<string, number>;
latest_children: Record<string, ChildReactionType>;
latest_children: ChildReactionsRecords<ReactionType, ChildReactionType, UserType>;
latest_children_extra?: Record<string, { next?: string }>;
own_children?: Record<string, ChildReactionType>;
own_children?: ChildReactionsRecords<ReactionType, ChildReactionType, UserType>;
user?: EnrichedUser<UserType>;
};

Expand Down