-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable microphone while muted #1329
Comments
hi @szechyjs, thanks for reporting this. Your assumption is correct, we use the mic for the speaking-while-muted notification. |
A joint PR that fixes a couple of related issues: - Adds an API that disables speaking while muted notifications - fixes #1329 - The selected device can't be reliably detected when audio or video filters are used - Audio tracks are now stopped (instead of disabled) on the Web - this should release the mic allocation - Fixed an issue in `usePersistedDevicePreferences()` where the camera and mic were automatically enabled after a call had been left - Pronto and Video Demo now remember the last used video filter and they enable it automatically
hi @szechyjs, we have just released a new SDK version that exposes the following APIs:
|
Thanks for the update. However, it seems that the microphone in use alert still displays in Android, even after setting edit: here is a rough example... const call = client.call('ptt', 'foo');
call.microphone.disableSpeakingWhileMutedNotification();
return (
<StreamVideo client={client}>
<StreamCall call={call} mediaDeviceInitialState={{ initialAudioEnabled: false }}>
<PTT />
</StreamCall>
</StreamVideo>
);
// ptt.tsx
const { microphone, isMute } = useMicrophoneState();
const ptt = async () => {
// on initial load of component, there is no mic alert until pressed as expected
await microphone.enable();
};
const pttEnd = async () => {
if (!isMute) {
// setting to disabled does not cause the mic alert to go away
await microphone.disable();
}
};
return (
<FAB
onPressIn={ptt}
onPressOut={pttEnd}
/>
); I wonder if it's related to: #1335 (comment) |
hi @szechyjs, Yes, the behavior you are describing is related to the linked comment. I didn't want to change the existing behavior for React Native as I wasn't sure about the impact. We will for sure revisit this change. In the meantime, I'll re-open this issue. |
I tried using |
hi @szechyjs, getting back to this. |
Which package/packages do you use?
@stream-io/video-react-sdk
@stream-io/video-react-native-sdk
@stream-io/video-client
Describe the solution you'd like
Currently when the microphone is muted via
micrphone.disable()
it just disables the track/stream. However, the microphone is still enabled on the device and is actively listening, I believe this is to support theSpeakingWhileMutedDetection
. It would be nice if it was possible to truly disable the microphone while muted, this is particularly useful in a PTT type of application. Without this our users see the microphone privacy/notification constantly active on their device, even though they muted (not pushing PTT).The text was updated successfully, but these errors were encountered: