Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devices): API to disable speaking while muted notifications #1335

Merged
merged 4 commits into from
May 3, 2024

Conversation

oliverlaz
Copy link
Member

Overview

A joint PR that fixes a couple of related issues:

  • Adds an API that disables speaking while muted notifications - fixes Disable microphone while muted #1329
  • The selected device can't be reliably detected when audio or video filters are used
  • Audio tracks are now stopped (instead of disabled) on the Web - this should release the mic allocation
  • Fixed an issue in usePersistedDevicePreferences() where the camera and mic were automatically enabled after a call had been left
  • Pronto and Video Demo now remember the last used video filter and they enable it automatically

Comment on lines +29 to +31
disableMode: TrackDisableMode = isReactNative()
? 'disable-tracks'
: 'stop-tracks',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szuperaz, we should check if this makes sense once you are back. This defaulted to disable-tracks for the mic, and stop-tracks for the camera. I don't know the reasons behind this.

I tested with Web, and now the mic indicator goes away once both, mic and speaking-while-muted notifications are disabled. I left the previous default for React Native.

@oliverlaz oliverlaz merged commit cdff0e0 into main May 3, 2024
18 of 20 checks passed
@oliverlaz oliverlaz deleted the device-handling-improvements branch May 3, 2024 11:33
@szechyjs szechyjs mentioned this pull request May 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable microphone while muted
1 participant