WIP faster join call flow - wip #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testableapple
approved these changes
May 15, 2023
ipavlidakis
approved these changes
May 15, 2023
| } | ||
| return "ERR" |
There was a problem hiding this comment.
Shouldn't we throw an error in this case?
There was a problem hiding this comment.
yes, not sure what's the best way to bubble / retry this
ipavlidakis
force-pushed
the
join-call-fast
branch
2 times, most recently
from
12f5bac
to
8a788af
Compare
- Remove LatencyService_Tests - Add hlsPlaylistUrl argument - Use wsEndpoint provided by SFUResponse - Update unit tests
ipavlidakis
force-pushed
the
join-call-fast
branch
from
8a788af
to
4ccc2db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the current join call flow with the one described here: https://www.notion.so/stream-wiki/Faster-Join-Flow-64dcb736e91741cc960f245503eb9798