Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Memory issue on SimulatorScreenCapturer #395

Merged
merged 1 commit into from
May 16, 2024

Conversation

ipavlidakis
Copy link
Collaborator

馃敆 Issue Links

Provide all JIRA tickets and/or GitHub issues related to this PR, if applicable.

馃幆 Goal

Describe why we are making this change.

馃摑 Summary

Provide bullet points with the most important changes in the codebase.

馃洜 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

馃帹 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

馃И Manual Testing Notes

Explain how this change can be tested manually, if applicable.

鈽戯笍 Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero 鈿狅笍 policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

馃巵 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@ipavlidakis ipavlidakis added the bug Something isn't working label May 15, 2024
@ipavlidakis ipavlidakis self-assigned this May 15, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner May 15, 2024 19:28
Copy link

1 Warning
鈿狅笍 Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 馃毇 Danger

Copy link

sonarcloud bot commented May 15, 2024

@ipavlidakis ipavlidakis merged commit a2cd70c into main May 16, 2024
12 checks passed
@ipavlidakis ipavlidakis deleted the fix/memory-leak-on-simulator-capturer branch May 16, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants