[Enhancement]Introduce Call caching and join state management #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ipavlidakis
changed the title
| switch currentStage.id { | ||
| case .joining: | ||
| break | ||
| case .joined where currentStage is StreamCallStateMachine.Stage.JoinedStage: |
There was a problem hiding this comment.
why do we need to cache the responses? Does that mean we call join from both callkit and the VM? (Thinking if throwing an error is better in this case)
| ) | ||
| } | ||
|
|
||
| let stage = try await stateMachine.publisher.nextValue(dropFirst: 1) |
There was a problem hiding this comment.
why do we need to drop the first one?
| @@ -23,15 +23,15 @@ import Foundation | |||
| /// additional overhead of dispatching tasks and managing thread execution in a DispatchQueue could result | |||
| /// in unnecessary latency, making `os_unfair_lock` the superior choice for scenarios where rapid, lightweight | |||
| /// synchronization is paramount. | |||
| final class UnfairQueue { | |||
| public final class UnfairQueue { | |||
There was a problem hiding this comment.
why do we need this one public? Would prefer if we keep it internal.
|
|
||
| log | ||
| .debug( | ||
| "Call updated \(oldValue != nil ? Unmanaged.passUnretained(oldValue!).toOpaque().debugDescription : "nil") → \(call != nil ? Unmanaged.passUnretained(call!).toOpaque().debugDescription : "nil"). Check the StateMachine for updates." |
There was a problem hiding this comment.
Why do we need to use Unmanaged.passUnretained here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Provide all JIRA tickets and/or GitHub issues related to this PR, if applicable.
🎯 Goal
Describe why we are making this change.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
imgimg🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)