Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color extension #466

Open
cmangen opened this issue Dec 28, 2017 · 5 comments
Open

Color extension #466

cmangen opened this issue Dec 28, 2017 · 5 comments
Labels

Comments

@cmangen
Copy link

cmangen commented Dec 28, 2017

Hi Anthony,

ContentTools is really awesome.

As I understood it correctly, you don't like a color selector in ContentTools.
Will such a feature be a lot of work? We can consider paying for this feature.

Thank you very much in advanced.

@chang-zhao
Copy link

chang-zhao commented Jan 1, 2018

IMHO inline styling with a couple of buttons (color & background-color) with drop-down pickers isn't a very complex task (though we would need to handle cases when the selected-for-coloring range overlaps elements with already existing color attributes).

But then that solution might be not the most useful - perhaps you would like to have only several specific colors on your page. Then it would be useful to keep a page colors palette, and perhaps a site-wide palette, create custom-color classes for them, and add that functionality to color picker buttons.

It's not too complex to consider to implement; it could be a very nice and useful feature.

@anthonyjb
Copy link
Member

@cmangen I can certainly create this for you or help you integrate an existing colour picker if that's your preference (email me at ant[at]getme.co.uk), however, if you're considering implementing this yourself (especially if you're going to use an existing 3rd-party colour picker component) it shouldn't be difficult.

There are several other developers who've created color picking tools for ContentTools as part of their editing environment (@bfintal certainly has), and they may well be willing to share some code here to help you get started.

@graydwarf
Copy link

graydwarf commented Jan 1, 2018 via email

@cmangen
Copy link
Author

cmangen commented Jan 4, 2018

@anthonyjb Thank you very much for your answer. Yes, I want to insert an existing one.

@STPJ
Copy link

STPJ commented Nov 29, 2018

Is this was implemented somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants