-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows #12
base: master
Are you sure you want to change the base?
Fix windows #12
Conversation
Rather than trying to get the code to use canonical paths, I've changed the tests to go with what the code does. This at least gets the tests working on Windows.
Your complimentary AppVeyor Windows CI config to test against Strawberry Perl. Turn it on at appveyor.com.
Can you show me the output of the failing tests? There have been several win32-specific fixes that have gone in lately, which have seemed to satisfy everyone else, so I'm concerned that applying this change will cause a regression in other win32 systems. Let's instead figure out what's going on. I know nothing about AppVeyor; what happens when this config file gets added? |
Sorry to forget the failure, and to explain AppVeyor. Both should be explained here. AppVeyor is like Travis, but for Windows and not as well integrated with Github yet. The config provided does a CI test against Strawberry Perl 5.20.1.1 (just happens to be the easiest Perl version to get). Like Travis, nothing will happen until you go to appveyor.com and turn it on. Unlike Travis, you have to configure Github notifications manually. http://www.appveyor.com/docs/notifications#github-pull-request Since you're maintaining a huge chunk of the tool chain now, and CPAN Windows testing is notoriously poor, it would be great to have you start using it! |
|
I'm encountering similar issues. Upon digging in, I think the problem is that the "%d" parameter is not using portable path separators. It appears that Dist::Zilla is using paths in "natural" form (i.e., unix-like, using '/' path separators), not in OS-canonical form. Given that, I think that the paths should be made canonical as late as possible. There are three repair sites:
I've made these repairs in PR#15 (which includes the changes introduced in P.S. Sorry for all the commit noise. I was testing various configurations and didn't realize that the commit message reference would continually ad to the conversation. :\ |
On a fresh Strawberry Perl 5.20.1 install (ie. AppVeyor) this is failing.
I found getting all the paths OS canonical a bit much, so I changed the tests. It's only human readable stuff and gets Windows passing.
I'm concerned that I couldn't find why this started failing. I see from CPAN Testers that it's been passing on Win32. Did something in the dependency chain change? Unfortunately CPAN Testers is erroring when I try to look at the passing results.