1.20.5 #4590
Merged
1.20.5 #4590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kas-tle
added
the
PR: Needs Testing
onebeastchris
added
Priority: High
PR: Feature
* Update the non-item parts * Add MaceItem * Fix registry data loading
Also fixes lecterns, and block break speed calculations
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
Previously, for any new tag, we would have to add a field, add the line to load it, add the line to clear it, and make a method for that tag. Now, you just add an enum.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various TODOs in no particular order
Creative item NBT -> componentTipped arrows(the client might rename the items for some reason)Refactor mappings recipes
test attribute displays <- seems like ATTRIBUTE_MODIFIERS isn't sent clientbound?????? or something
dyeable items - seems like it's still somewhat hardcoded.armadilloAnvil verificationFirework verificationGoat hornsBanner pick item
Banner item bedrock -> java translationLodestone compass tracked / GlobalPos can be null
test CanPlaceOn
Spigot adapters (paper reflection changes.. yay)figure out why modinjector isn't used