Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused exceptions, use java 9+ features and checkerframework, other cleanup #780

Merged
merged 14 commits into from
Jan 4, 2024
Merged

Remove unused exceptions, use java 9+ features and checkerframework, other cleanup #780

merged 14 commits into from
Jan 4, 2024

Conversation

AlexProgrammerDE
Copy link
Contributor

No description provided.

davidmayr and others added 5 commits December 20, 2023 13:54
@davidmayr
Fix DataPalette index & deprecate unused globalPaletteBits (GeyserMC#775
809a0c5 
)

* fix: datapalette not working correctly

* feat: deprecate global palette bits

* chore: redirect deprecated createEmpty call to new one
@Kas-tle
Resolve fallout from globalPaletteBits removal (GeyserMC#777)
d3cc9d4 
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
@AlexProgrammerDE
Create jitpack.yml (GeyserMC#778)
eaac051
@AlexProgrammerDE
Initial work on non breaking changes/cleanup
2b50e99
@AlexProgrammerDE
Cleanup
d9d0539
onebeastchris
onebeastchris requested changes Dec 23, 2023
View reviewed changes
Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just a few tiny things

src/main/java/com/github/steveice10/mc/protocol/codec/MinecraftCodecHelper.java Show resolved Hide resolved
src/main/java/com/github/steveice10/mc/protocol/data/game/entity/metadata/ByteMetadataType.java Show resolved Hide resolved
...com/github/steveice10/mc/protocol/packet/ingame/clientbound/ClientboundAwardStatsPacket.java Show resolved Hide resolved
@AlexProgrammerDE AlexProgrammerDE marked this pull request as ready for review December 23, 2023 13:47
@AlexProgrammerDE AlexProgrammerDE changed the base branch from master to dev December 23, 2023 18:46
Kas-tle
Kas-tle reviewed Dec 31, 2023
View reviewed changes
.editorconfig Outdated Show resolved Hide resolved
onebeastchris
onebeastchris reviewed Dec 31, 2023
View reviewed changes
Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just the one annotation

...10/mc/protocol/packet/ingame/serverbound/inventory/ServerboundSetCreativeModeSlotPacket.java Outdated Show resolved Hide resolved
@Konicai Konicai changed the title Non breaking changes/cleanup Remove IOExceptions for packets, use java 9+ features and checkerframework, other cleanup Jan 4, 2024
@Konicai Konicai changed the title Remove IOExceptions for packets, use java 9+ features and checkerframework, other cleanup Remove unused exceptions, use java 9+ features and checkerframework, other cleanup Jan 4, 2024
@Konicai Konicai merged commit 8d4878c into GeyserMC:dev Jan 4, 2024
1 check passed
AlexProgrammerDE added a commit to AlexProgrammerDE/MCProtocolLib that referenced this pull request Apr 24, 2024
@AlexProgrammerDE
Remove unused exceptions, use java 9+ features and checkerframework, …
4e54830 
…other cleanup (GeyserMC#780)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim203 Tim203 Tim203 left review comments

@Kas-tle Kas-tle Kas-tle left review comments

@Konicai Konicai Konicai approved these changes

@onebeastchris onebeastchris onebeastchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AlexProgrammerDE @Tim203 @Kas-tle @Konicai @onebeastchris @davidmayr