Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server name support #7

Merged
merged 17 commits into from Sep 10, 2019
Merged

Server name support #7

merged 17 commits into from Sep 10, 2019

Conversation

fastlorenzo
Copy link
Contributor

Added server name support for static servers. This is useful to reference servers by name, and a quick fix if you have multiple IPs per server (create multiple 'servers' in Ghostwriter, and assign them the same server name)

@covertgeek
Copy link
Collaborator

covertgeek commented Aug 2, 2019

Referencing #6. It looks like this was implemented as part of this pull request also.

@fastlorenzo
Copy link
Contributor Author

Fixing #10 as well

@covertgeek
Copy link
Collaborator

@fastlorenzo -- I just wanted to let you know we aren't ignoring this pull request. Since there are model changes, I'd like to work with Chris before accepting it.

He's participating in the BlackHat conference this week and we'll pick it up next week.

@fastlorenzo
Copy link
Contributor Author

@covertgeek no issues, I guessed you should be quite busy this week 👍

On a side not, I have other ideas for the tool, I'll put that in an issue and see if I have time to work on that as well

Updated admin section's User form to allow changing of passwords in a…
@chrismaddalena
Copy link
Collaborator

Starting a review now that some of the big changes have ben merged. Only conflicts are some HTML files, so looks good so far. That was my biggest fear, that the PR would conflict with planned/in-progress updates.

@fastlorenzo
Copy link
Contributor Author

@chrismaddalena should be fixed now

@fastlorenzo
Copy link
Contributor Author

Added the support for transient servers as well, and fixed some layout issues.

@chrismaddalena
Copy link
Collaborator

@fastlorenzo This all looks great! Thank you for taking the work of getting everything ready to merge off of my plate, too. I just pulled the PR and ran some tests. Everything looks good and I really like the changes. This will be merged 😃

@chrismaddalena chrismaddalena merged commit 74da0ab into GhostManager:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants