What is the purpose of sanitization for output files?

[okazymyrov]

In asktgt the output file is sanitized when a full path for ticket output is used (e.g., "C:\Folder 1\Folder2\ticket.kirbi"). The result is saved into the folder with rubeus.exe instead of provided output. What is the purpose of sanitization?

Ref:

Rubeus/Rubeus/lib/Ask.cs

Line 206 in 0754532

outfile = Helpers.MakeValidFileName(outfile);

[leezp]

output doesn't ;
i tried Rubeus.exe monitor /output:.\a.txt

[leezp]

@HarmJ0y can you fix "outfile" parameter? doesn't work

[HarmJ0y]

The purpose of sanitization is to strip invalid characters from an output file name

Rubeus/Rubeus/lib/Helpers.cs

Lines 275 to 283 in afa7ca1

	// Great method from http://forcewake.me/today-i-learned-sanitize-file-name-in-csharp/
	static public string MakeValidFileName(string name)
	{
	string invalidChars = new string(Path.GetInvalidFileNameChars());
	string escapedInvalidChars = Regex.Escape(invalidChars);
	string invalidRegex = string.Format(@"([{0}]*\.+$)|([{0}]+)", escapedInvalidChars);
	return Regex.Replace(name, invalidRegex, "_");
	}

[HarmJ0y]

@leezp The /outfile parameter is not valid for the monitor command. For future issues, please make sure to read either:

• The default Rubeus.exe help output
• The extensive README.md or
• The source of the command you're having issues with that controls the flags passed.

[leezp]

@leezp The /outfile parameter is not valid for the monitor command. For future issues, please make sure to read either:

• The default Rubeus.exe help output
• The extensive README.md or
• The source of the command you're having issues with that controls the flags passed.

if you can add some enhancement and fix it?

[okazymyrov]

Please note that the original issue was for asktgt, and not for monitor.