Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exporting to full paths #109

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

VbScrub
Copy link
Contributor

@VbScrub VbScrub commented Nov 23, 2021

Fixes #76 and fixes #63

Tested with asktgt and the following paths as the /outfile argument and all works as it should:

C:\test\ticket.txt
\ticket.txt
C:\invalid/chars*.txt - file gets written to C:\invalid_chars_.txt
invalid/chars*.txt - file gets written to invalid_chars_.txt in working directory

For the record I still think we should ditch the whole file name sanitization thing, especially as it is not used universally throughout the program (kerberoasting for example does not sanitize file names, so that already let you use full paths for /outfile).

New PR as I messed up the old one

@VbScrub
Copy link
Contributor Author

VbScrub commented Nov 23, 2021

Hopefully this PR won't get affected by other changes I make in my own fork

@HarmJ0y HarmJ0y merged commit 0f5cc4f into GhostPack:master Dec 13, 2021
@VbScrub VbScrub deleted the FileNameFix branch January 7, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for full path in /output What is the purpose of sanitization for output files?
2 participants