Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76 and fixes #63
Tested with
asktgt
and the following paths as the/outfile
argument and all works as it should:C:\test\ticket.txt
\ticket.txt
C:\invalid/chars*.txt
- file gets written toC:\invalid_chars_.txt
invalid/chars*.txt
- file gets written toinvalid_chars_.txt
in working directoryFor the record I still think we should ditch the whole file name sanitization thing, especially as it is not used universally throughout the program (kerberoasting for example does not sanitize file names, so that already let you use full paths for
/outfile
).New PR as I messed up the old one