-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyload depreciation notice #1475
Comments
Indeed it is. Thanks for the tip. I think there's been a few deprecations I need to go through. I'll try to find some time to do it soon. We will need to try running the deprecated container to create a config and then upgrading to the ng container to see if the config still works. If it does then the best action is probably to replace the image in the existing pyload files in the DS repo. If the config does not work (and requires a new config for the ng version) then it will probably mean we will need to deprecate pyload in DS and make new templates with the name |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@nemchik do you want to do the same thing we did for the other recently deprecated application? Create a whole new application and set this one to deprecated? |
If the app supports direct upgrading we can just change the image and keep everything else the same. If the app advises against direct upgrading, or we can't confirm it works, then deprecating and creating new is the way to go. |
Well this is an LSIO image soooo thats all you to tell us 🤣 |
There's no clear indication in the lsio docs, or in the pyload docs (upstream), so we'll have to test it. |
I am not sure if either of you have Pyload loaded, but I have been using it for a while so I can test if you need someone to test |
I do not have it installed nor would I know how to test. I would say that the easiest way for you to test would be to modify your |
would I modify the docker-compose or the docker-compose.override?
app
…On Tue, Aug 16, 2022 at 9:05 PM Angry Cuban ***@***.***> wrote:
I do not have it installed nor would I know how to test. I would say that
the easiest way for you to test would be to modify your docker-compose.yml
and change the pyload image with the new one and run ds -c up pyload and
let us know of any issues. If there are no issues we can make the change
—
Reply to this email directly, view it on GitHub
<#1475 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLHMYSYBNGBLWHFGQZAYDDVZQ3GXANCNFSM5V3CUXLQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
*Don't hold onto a mistake just because you spent a long time making it. *
Aaron Perrault
***@***.***
|
You can do either. The "correct" way would be to create an override file and define the image there and run |
OK. I am working from home tomorrow so i will try that and see if i run
into any issues
app
…On Wed, Aug 17, 2022 at 6:21 PM Angry Cuban ***@***.***> wrote:
You can do either. The "correct" way would be to create an override file
and define the image there and run ds -c up
—
Reply to this email directly, view it on GitHub
<#1475 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLHMYXTMWGJ4SK443GYUO3VZVQVLANCNFSM5V3CUXLQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
*Don't hold onto a mistake just because you spent a long time making it. *
Aaron Perrault
***@***.***
|
i added the following to my override
pyload:
image: lscr.io/linuxserver/pyload-ng:latest
container_name: pyload
and then ran ds -c up pyload. Pyload started just fine, but it wiped out
the old settings.
looks like we are going to have to deprecate it and just add the new one as
a new container
app
…On Wed, Aug 17, 2022 at 8:31 PM Aaron Perrault ***@***.***> wrote:
OK. I am working from home tomorrow so i will try that and see if i run
into any issues
app
On Wed, Aug 17, 2022 at 6:21 PM Angry Cuban ***@***.***>
wrote:
> You can do either. The "correct" way would be to create an override file
> and define the image there and run ds -c up
>
> —
> Reply to this email directly, view it on GitHub
> <#1475 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABLHMYXTMWGJ4SK443GYUO3VZVQVLANCNFSM5V3CUXLQ>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
*Don't hold onto a mistake just because you spent a long time making it. *
Aaron Perrault
***@***.***
--
*Don't hold onto a mistake just because you spent a long time making it. *
Aaron Perrault
***@***.***
|
Ah bummer, sounds good thanks for testing! |
The current image is deprecated and on https://hub.docker.com/r/linuxserver/pyload suggest to migrate to https://github.com/linuxserver/docker-pyload-ng.
It is not a bug but just for you guys to know
The text was updated successfully, but these errors were encountered: