Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Work in Progress] Tests: phpunit codecepton upgrade #1223

Merged
merged 6 commits into from
Jan 27, 2021
Merged

[Work in Progress] Tests: phpunit codecepton upgrade #1223

merged 6 commits into from
Jan 27, 2021

Conversation

yookoala
Copy link
Member

Description

Motivation and Context

How Has This Been Tested?
Tested in a branch in my fork.

Screenshots
2021-01-26 20-54-23 的螢幕擷圖

@yookoala
composer: migrate php version to 7.3
a07df0d 
* Change both the required php version and forced platform version
  from 7.0 to 7.3.
@yookoala
composer: Upgraded phpunit and codeception
510105a 
* Upgrade phpunit to ^9.3
* Upgrade codeception to ^4.1.9
* Add codeception/module-phpbrowser to dependencies because it's
  no longer installed with codeception by default.
@yookoala
Tests: add codeception-module-db in require-dev
cc77c21 
* Codeception 4 no longer includes the db module by default. Install
  to make the tests work.
@yookoala
Tests: add codeception-module-filesystem in require-dev
4c680b5 
* Codeception 4 no longer includes the Filesystem module by default.
  Install to make the tests work.
@yookoala
Tests: add codeception-module-assert in require-dev
ec0d701 
* Codeception 4 no longer includes the Assert module by default.
  Install to make the tests work.
@yookoala
Copy link
Member Author

yookoala commented Jan 26, 2021 •
edited
Loading

I have an experimental branch here with everything merged. Everything works, include the test in PHP 8 environment.

CI Test result:
https://github.com/yookoala/GibbonEduCore/actions/runs/512531631

SKuipers
SKuipers approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@SKuipers SKuipers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally by merging in all the other changes and it's looking good. Going to merge this one in and see how the tests run. Thanks!

@SKuipers SKuipers merged commit 1f889fd into GibbonEdu:v22.0.00 Jan 27, 2021
@yookoala yookoala deleted the feature/phpunit-codecepton-upgrade branch January 27, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SKuipers SKuipers SKuipers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHPUnit / Codeception errors in PHP 8
2 participants
@yookoala @SKuipers