Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: fix TestCase for phpunit 9 #1221

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

yookoala
Copy link
Member

@yookoala yookoala commented Jan 26, 2021

Description

  • Fix forward all unit test compatibiliy with phpunit 9 by updating setUp and tearDown function signatures.

Motivation and Context

  • Newer PHPUnit TestCase setUp and tearDown method needs to specifically hint to return "void".
  • The change is backward compatible. Loose parent methods are compatible with strict children implementations.
  • This fixed a few errors that block PHPUnit / Codeception errors in PHP 8 #1214.

How Has This Been Tested?
On CI platform.

* Fix forward all unit test compatibiliy with phpunit 9 by
  updating setUp and tearDown function signatures.
Copy link
Member

@SKuipers SKuipers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You're really streamlining the test process. I know we were frozen on the same PHPUnit/Codeception versions for a while to try and keep things from breaking, great to see you updating these and untangling the issues. Hugely appreciated 😃

@SKuipers SKuipers merged commit 9027147 into GibbonEdu:v22.0.00 Jan 27, 2021
@yookoala yookoala deleted the fix/phpunit9-testcase branch January 27, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants