Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities: Activity Enrolment Summary report ooification #611

Merged

Conversation

SKuipers
Copy link
Member

@SKuipers SKuipers commented Sep 6, 2018

This PR sets up the functionality for DataTables used on report pages, enabling them to be displayed as an HTML table as well as easily printed and exported.

The ooified logic uses a format url parameter to determine the type of data table to render. In the future when we implement routing this parameter can be part of the controller request-response handling to automatically apply the right template and headers based on the content type.

  • OOifies the Activity Enrolment Summary as an example.
  • Adds a PrintableRenderer for the DataTable, which displays a title with the table and strips out any Action/Expandable columns.
  • Adds row-highlighting logic to the SpreadsheetRenderer class.
  • Creates an export.php front-controller for pages that require no HTML headers/output.
  • Adds some print css styles, particularly to prevent page breaks inside a table row.

@rossdotparker rossdotparker merged commit 3a78bf8 into GibbonEdu:v17.0.00 Sep 11, 2018
@SKuipers SKuipers deleted the feature/Activity_Report_OOification branch September 12, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants