Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarks #10

Closed
Tracked by #81
Gigas002 opened this issue Jul 6, 2019 · 2 comments
Closed
Tracked by #81

Update benchmarks #10

Gigas002 opened this issue Jul 6, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request grabbed Someone's already working on this issue
Projects
Milestone

Comments

@Gigas002
Copy link
Owner

Gigas002 commented Jul 6, 2019

In order to improve benchmarks results, I'd like to add Gdal2Tiles.exe with multiprocessing ability. I'm very new to Python/PyInstaller, so I couldn't do it by myself (my converted .exe file throws errors, when I try to run it with --processes argument).
So, if you can do this, please, convert gdal2tiles.py to .exe with ability to run in multiprocessing mode and link the binaries for windows here.
And it would be even better, if you'll write how to do this, so I'll be able to always use the latest version of Gdal2Tiles in benchmarks.

P.S.
I tried to add this to gdal2tiles.py (StackOverflow discussion of similar question):

if __name__ == '__main__':
    multiprocessing.freeze_support()

But still, that didn't help.

@Gigas002 Gigas002 added enhancement New feature or request help wanted Extra attention is needed labels Jul 6, 2019
@Gigas002 Gigas002 added the up-for-grabs Feel free to work on this issue label Jul 21, 2020
@Gigas002
Copy link
Owner Author

Gigas002 commented Aug 4, 2020

  • Probably can use docker images of gdal and MapTiler
  • Use newest MapTiler
  • Use benchmarksdotnet

@Gigas002 Gigas002 added this to In progress in Benchmarks Aug 5, 2020
@Gigas002
Copy link
Owner Author

Gigas002 commented Aug 5, 2020

Depends on all issues for Milestone 2.0.0 from Core and Tests projects.

After they're complete, it's safe to update the benchmarks app.

Steps before releasing:

  • Use latest gdal2tiles.py (try docker)
  • Use latest maptiler (if possible, probably can use docker image)
  • Use benchmarkdotnet for more precise results

@Gigas002 Gigas002 added this to the 2.0.0 milestone Aug 5, 2020
@Gigas002 Gigas002 self-assigned this Aug 5, 2020
@Gigas002 Gigas002 added grabbed Someone's already working on this issue and removed help wanted Extra attention is needed up-for-grabs Feel free to work on this issue labels Aug 5, 2020
@Gigas002 Gigas002 changed the title Improve benchmarks Update benchmarks Aug 5, 2020
@Gigas002 Gigas002 moved this from In progress to To do in Benchmarks Aug 6, 2020
Benchmarks automation moved this from To do to Done Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request grabbed Someone's already working on this issue
Projects
Benchmarks
  
Done
Development

No branches or pull requests

1 participant