Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow semver #62

Closed
TatriX opened this issue Dec 3, 2019 · 4 comments
Closed

Follow semver #62

TatriX opened this issue Dec 3, 2019 · 4 comments

Comments

@TatriX
Copy link

TatriX commented Dec 3, 2019

According to semver one should bump major version when introducing incompatible API changes.
#59 introduced breaking changes and thus broke others code.
Thanks!

@GildedHonour
Copy link
Owner

I don't follow the recommendations of semver.

@GildedHonour
Copy link
Owner

Thanks for what?

@TatriX
Copy link
Author

TatriX commented Dec 6, 2019

This is unfortunate, because that's what people expect: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

It would be nice if you could mention this fact in the readme, so users of the library could pin dependency to a specific version.

Thanks for you work on the useful package.

@GildedHonour
Copy link
Owner

Useful package? Ahhhaaa. Nothing useful in it.

Don't worry about other users. No user has ever complained about bumping the major version.

TatriX added a commit to TatriX/realworld-rust-rocket that referenced this issue Dec 9, 2019
TatriX added a commit to TatriX/realworld-rust-rocket that referenced this issue Dec 9, 2019
TatriX added a commit to TatriX/realworld-rust-rocket that referenced this issue Dec 9, 2019
pinocchio338 added a commit to pinocchio338/real-world-rust that referenced this issue Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants