Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frank JWT decode #20

Merged
merged 1 commit into from Dec 3, 2019
Merged

Fix Frank JWT decode #20

merged 1 commit into from Dec 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2019

The function decode has changed to Frank_jwt and needs 4 parameters

The function decode has changed to Frank_jwt and needs 4 parameters
@TatriX
Copy link
Owner

TatriX commented Dec 3, 2019

Thanks for the PR.
It's a bit strange though that on travis it tried to compile frank_jwt v3.1.2 when it has an explicit version of 3.1.1 in Cargo.toml. It would be nice to find out how this happened in the first place to prevent this from happening in the future.

@TatriX
Copy link
Owner

TatriX commented Dec 3, 2019

Ok, my bad:

... 0.1.0” does not mean exactly 0.1.0, it’s a synonym for “^0.1.0”. You want “=0.1.0” to get exact.

@TatriX TatriX merged commit 422f33b into TatriX:master Dec 3, 2019
@ghost
Copy link
Author

ghost commented Dec 3, 2019

Thats true
I have the same problem on my Localen computer.
the version from Cargo.toml is ignored.

The string "3.1.1" is a semver version requirement. Since this string does not have any operators in it, it is interpreted the same way as if we had specified "^3.1.1", which is called a caret requirement.

@ghost
Copy link
Author

ghost commented Dec 3, 2019

Ok, my bad:

... 0.1.0” does not mean exactly 0.1.0, it’s a synonym for “^0.1.0”. You want “=0.1.0” to get exact.

Found the same :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant