Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for analysis workflow functions #1610

Merged
merged 19 commits into from
Jul 18, 2024
Merged

Update tests for analysis workflow functions #1610

merged 19 commits into from
Jul 18, 2024

Conversation

lauramaxwell
Copy link
Contributor

Overview

added yaml files to tests/testthat/testdata for use in analysis workflow tests and added tests double programming with yaml workflows for relevant functions.

closes #1551

Test Notes/Sample Code

Notes:

@lauramaxwell
Copy link
Contributor Author

needs some sprucing up. @lauramaxwell will update this next week during the v2 qc/documentation blitz.

@lauramaxwell lauramaxwell marked this pull request as draft July 10, 2024 15:47
@jonthegeek jonthegeek marked this pull request as ready for review July 16, 2024 18:12
@jonthegeek
Copy link
Contributor

100% test coverage for the files mentioned in #1551 🎉🎉🎉

@jonthegeek jonthegeek marked this pull request as draft July 16, 2024 18:14
@jonthegeek
Copy link
Contributor

Back to draft until I review #1666. That will impact this one a lot so I'd rather finish that review before finalizing this.

@jonthegeek jonthegeek marked this pull request as ready for review July 16, 2024 18:37
jonthegeek
jonthegeek reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should be using some sampleData in here. Probably not to fully test the workflow path? I'm not sure.

tests/testthat/testdata/create_double_data.R Show resolved Hide resolved
lauramaxwell
lauramaxwell commented Jul 17, 2024
View reviewed changes
Copy link
Contributor Author

@lauramaxwell lauramaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! have a few comments for some sampleData usage in a few spots, etc.

tests/testthat/test-Transform_Rate.R Outdated Show resolved Hide resolved
tests/testthat/test-Transform_Rate.R Outdated Show resolved Hide resolved
tests/testthat/test-Transform_Rate.R Outdated Show resolved Hide resolved
tests/testthat/testdata/test_workflow.yaml Outdated Show resolved Hide resolved
tests/testthat/testdata/create_double_data.R Show resolved Hide resolved
jonthegeek
jonthegeek approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (and @lauramaxwell said so, too)

@jonthegeek jonthegeek merged commit 2eacba1 into dev Jul 18, 2024
6 checks passed
@jonthegeek jonthegeek deleted the fix-1551 branch July 18, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonthegeek jonthegeek jonthegeek approved these changes

@jwildfire jwildfire Awaiting requested review from jwildfire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QC: Robust unit tests for analysis pipeline
2 participants
@lauramaxwell @jonthegeek