Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TimeOnly, DateOnly & Timestamp #53

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Support for TimeOnly, DateOnly & Timestamp #53

merged 1 commit into from
Aug 27, 2022

Conversation

unconverged
Copy link
Contributor

Hi!
This pull requests brings support for time-related columns: TIME, DATE and TIMESTAMP. For TIMESTAMP columns we use DateTime. However, because TimeOnly and DateOnly types are only available since .net 6, we use our own types that can be converted to and from DateTime.

Fix #45

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2842292080

  • -12 of 105 (88.57%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.9%) to 77.652%

Changes Missing Coverage Covered Lines Changed/Added Lines %
DuckDB.NET.Data/Internal/PreparedStatement.cs 4 5 80.0%
DuckDB.NET.Data/DuckDBDataReader.cs 5 7 71.43%
DuckDB.NET/DuckDBNativeObjects.cs 9 12 75.0%
DuckDB.NET.Data/DuckDBParameter.cs 7 13 53.85%
Totals Coverage Status
Change from base Build 2728373780: 3.9%
Covered Lines: 509
Relevant Lines: 634

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 11, 2022

Pull Request Test Coverage Report for Build 2940255845

  • 63 of 68 (92.65%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.8%) to 84.66%

Changes Missing Coverage Covered Lines Changed/Added Lines %
DuckDB.NET.Data/DuckDBDataReader.cs 9 11 81.82%
DuckDB.NET/DuckDBNativeObjects.cs 0 3 0.0%
Totals Coverage Status
Change from base Build 2934145529: 2.8%
Covered Lines: 582
Relevant Lines: 676

💛 - Coveralls

@unconverged unconverged mentioned this pull request Aug 20, 2022
@Giorgi Giorgi merged commit 18b0a7b into Giorgi:main Aug 27, 2022
@unconverged unconverged deleted the date-types branch August 27, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: DateOnly and TimeOnly
3 participants