Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date types simplified #59

Closed
wants to merge 4 commits into from
Closed

Date types simplified #59

wants to merge 4 commits into from

Conversation

unconverged
Copy link
Contributor

@unconverged unconverged commented Aug 20, 2022

This pull request is mostly equal to #53 , but uses DateTime to represent DateOnly and TimeOnly columns. As a result for DuckDb's DATE columns we return a DateTime with time-related properties set to 0s and for TIME columns we return a DateTime with date-related properties set to 1s (min values for the corresponding properties).

This PR substitutes #53 , we need to choose one of them.

Fix #45

Support for TimeOnly, DateOnly & Timestamp
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2894364867

  • -8 of 93 (91.4%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.2%) to 74.789%

Changes Missing Coverage Covered Lines Changed/Added Lines %
DuckDB.NET.Data/Internal/PreparedStatement.cs 4 5 80.0%
DuckDB.NET.Data/DuckDBParameter.cs 3 5 60.0%
DuckDB.NET.Data/Types/DuckDBTimestamp.cs 68 70 97.14%
DuckDB.NET/DuckDBNativeObjects.cs 9 12 75.0%
Totals Coverage Status
Change from base Build 2890051285: 4.2%
Covered Lines: 506
Relevant Lines: 657

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 20, 2022

Pull Request Test Coverage Report for Build 2895966035

  • 126 of 156 (80.77%) changed or added relevant lines in 6 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.8%) to 76.437%

Changes Missing Coverage Covered Lines Changed/Added Lines %
DuckDB.NET.Data/Internal/PreparedStatement.cs 15 16 93.75%
DuckDB.NET.Data/Types/DuckDBTimestamp.cs 68 70 97.14%
DuckDB.NET/DuckDBNativeObjects.cs 9 12 75.0%
DuckDB.NET.Data/DuckDBDataReader.cs 11 21 52.38%
DuckDB.NET.Data/DuckDBParameter.cs 15 29 51.72%
Files with Coverage Reduction New Missed Lines %
DuckDB.NET.Data/DuckDBDataReader.cs 14 59.41%
Totals Coverage Status
Change from base Build 2890051285: 5.8%
Covered Lines: 558
Relevant Lines: 715

💛 - Coveralls

@unconverged unconverged changed the title Date types simple Date types simplified Aug 20, 2022
@Giorgi Giorgi closed this Aug 27, 2022
@unconverged unconverged deleted the date-types-simple branch August 27, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: DateOnly and TimeOnly
3 participants