Merge pull request #885 from tlnagy/fix-broadcast-type-coercion

fix inexacterrors caused by type coercion in broadcast
GiovineItalia · Aug 28, 2016 · 1196f07 · 1196f07
2 parents f6183ac + 7c3590d
commit 1196f07
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/statistics.jl b/src/statistics.jl
@@ -1749,8 +1749,9 @@ function apply_statistic(stat::JitterStatistic,
     rng = MersenneTwister(stat.seed)
     for var in stat.vars
         data = getfield(aes, var)
-        broadcast!(+, data, data, stat.range * (rand(rng, length(data)) - 0.5) .* span)
-        setfield!(aes, var, data)
+        outdata = Array(Float64, size(data))
+        broadcast!(+, outdata, data, stat.range * (rand(rng, length(data)) - 0.5) .* span)
+        setfield!(aes, var, outdata)
     end
 end
 

diff --git a/test/jitter.jl b/test/jitter.jl
@@ -4,4 +4,6 @@ using Gadfly, DataArrays, RDatasets
 plot(dataset("datasets", "iris"), x=:SepalLength, y=:SepalWidth, color=:Species,
      Stat.x_jitter, Stat.y_jitter, Geom.point)
 
-
+# make sure type-coercion works properly, the `y` values here are integers
+# but will be coerced into floats.
+plot(x=rand(500), y=rand(1:4, 500), Stat.y_jitter(range=0.5), Geom.point)