Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagging 0.7 #1140

Closed
bjarthur opened this issue Apr 27, 2018 · 12 comments
Closed

tagging 0.7 #1140

bjarthur opened this issue Apr 27, 2018 · 12 comments

Comments

@bjarthur
Copy link
Member

would be good to tag a new release which fixes the dataframes problem. are there any PRs we should merge before hand?

@Mattriks since #1118 introduces a breaking change, would be good to do that now as otherwise we'd have to wait awhile.

@non-Jedi what is your time frame for #1105 ?

i've been diligently working on #1116, but that is something that could wait.

@non-Jedi
Copy link
Contributor

backburner for me right now. Hope to get to it some time after May 10.

@tlnagy
Copy link
Member

tlnagy commented Apr 27, 2018

Lets leave this open for 24 hours and see if @Mattriks wants to get #1118 ready for this release. We should try and get these DataFrames fixes out ASAP.

@Mattriks
Copy link
Member

There are two issues to do with IndirectArrays described in #1130, so those 2 things work in Gadfly 0.6.5 but not on master. Is there a plan to fix them?

Getting #1118 release-ready should be possible, I'll try to do it within a week.

@tlnagy
Copy link
Member

tlnagy commented May 9, 2018

I've been using master for the past couple weeks and it's performed well for me. I think that we need to tag and push it out because Gadfly is interfering with the rest of the dataframes ecosystem. We'll have to accept the regression on #1130 until @andreasnoack has a chance to look into it.

@bjarthur
Copy link
Member Author

bjarthur commented May 9, 2018

agreed. specifically, see #1144.

@andreasnoack please let us know your timeframe so we can decide whether to tag now or wait. we appreciate all you work on the dataframes issue!

@bjarthur
Copy link
Member Author

bjarthur commented May 17, 2018

i'm inclined to tag this weekend unless someone convinces me it's a bad idea.

[EDIT: because there were two more gripes recently on slack about the dataframes incompatibility).

@aviks
Copy link
Collaborator

aviks commented May 20, 2018

I would urge a tag, even with some regressions, as soon as possible. The dependence of Gadfly on old DataFrames has unfortunately caused a huge split, with many strange dependencies.

Did you know for example, that if you install Gadfly, you cannot now install a new version of ZMQ? (The reasons are arcane, and honestly not the Gadfly developers problem, just an unfortunate side effect -- but still something that is very painful for many users).

@bjarthur
Copy link
Member Author

tagging now

@bjarthur
Copy link
Member Author

@KristofferC
Copy link
Contributor

Merged.

@aviks
Copy link
Collaborator

aviks commented May 21, 2018

Thanks!

@bjarthur
Copy link
Member Author

close by JuliaLang/METADATA.jl#14746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants