Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to control key background and outline in Theme #1515

Open
tlnagy opened this issue Jan 25, 2021 · 2 comments
Open

Add ability to control key background and outline in Theme #1515

tlnagy opened this issue Jan 25, 2021 · 2 comments

Comments

@tlnagy
Copy link
Member

tlnagy commented Jan 25, 2021

If placing the key inside a plot, it would be nice to be able to set the key background color and outline. For example, for this plot style, it would be to have a white background and black outline for the key too.

image

@Mattriks
Copy link
Member

The way to do this would be similar to #1458,. Make a new struct like:

struct BoxFormat
    fill
    stroke
    linewidth
    etc
end

which could be accepted by new Theme fields e.g. Theme(panelbox=boxformat(...), keybox=boxformat(...)). For panel and background, the old Theme fields (panel_fill, panel_stroke etc) can be deprecated.

@tlnagy
Copy link
Member Author

tlnagy commented Jan 25, 2021

I think that's a good idea. Going forward, I think Theme would benefit from a hierarchical construction which also allows sharing of subthemes in a CSS-like manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants